Address warning about try used on a method that does not throws
#8099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
added
the
category: tooling
Collaborator
You can test the changes from this Pull Request by:
|
jkmassel
approved these changes
Nov 11, 2022
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Hmm the use of async -> Result is unfortunate here, but probably not worth fixing the wider issue at this point – this seems like a sensible improvement for sure.
Contributor
Author
Yes. There are 24 matches for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is says on the title...
Testing instructions
If CI builds, then this code change is correct. Feel free to verify by comparing warnings on
trunkand this branc.RELEASE-NOTES.txtif necessary.